Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename L1ChainID to ChainID in Config to Avoid Ambiguity in L1/L2 Transaction Handling #88

Open
rachit77 opened this issue Jan 10, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@rachit77
Copy link
Contributor

Description:

Since the tx-manager handles both L1 and L2 transactions, the current field name L1ChainID can be misleading. To make it more intuitive, it should be renamed to ChainID.

// Config represents the configuration of the etherman
type Config struct {
	// URL is the URL of the Ethereum node for L1
	URL string `mapstructure:"URL"`

	// allow that L1 gas price calculation use multiples sources
	MultiGasProvider bool `mapstructure:"MultiGasProvider"`
	// Configuration for use Etherscan as used as gas provider, basically it needs the API-KEY
	Etherscan etherscan.Config
	// L1ChainID is the chain ID of the L1
	L1ChainID uint64 `mapstructure:"L1ChainID"`
	// HTTPHeaders are the headers to be used in the HTTP requests
	HTTPHeaders map[string]string `mapstructure:"HTTPHeaders"`
}

reference

By renaming it to ChainID, the purpose of the field becomes clearer in the context of both L1 and L2 transactions.

@rachit77 rachit77 self-assigned this Jan 10, 2025
@rachit77 rachit77 added the enhancement New feature or request label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant