Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to add additional labels to the connect serviceMonitor #195

Open
jhoblitt opened this issue May 6, 2024 · 0 comments
Open

Ability to add additional labels to the connect serviceMonitor #195

jhoblitt opened this issue May 6, 2024 · 0 comments

Comments

@jhoblitt
Copy link

jhoblitt commented May 6, 2024

Summary

PR #151 introduced a serviceMonitor but did not include a parameter to add additional labels to the resource.

Use cases

  • In my environment, we use labels on serviceMonitors to control scraping.

Proposed solution

Add support for connect.serviceMonitor.additionalLabels as is commonly supported in other charts.

Is there a workaround to accomplish this today?

The only option today is to add labels to all connect resources via connect.labels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhoblitt