Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nauty interface bug + add more documentation #143

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

kris-brown
Copy link
Collaborator

@kris-brown kris-brown commented Jun 12, 2024

A bug popped up in running Nauty on the arrow category for graphs, which led to cleaning up some of the code (which addressed the bug) and adding better documentation.

This addresses a separate bug for schemas with loops (e.g. DDS): a unique filter was needed when adding the $\phi_{dom}$ and $\phi_{codom}$ edges to the simple undirected graph representation of the ACSet.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (6407367) to head (40f0c47).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   91.61%   91.83%   +0.22%     
==========================================
  Files          23       23              
  Lines        2098     2106       +8     
==========================================
+ Hits         1922     1934      +12     
+ Misses        176      172       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kris-brown kris-brown added the bug Something isn't working label Jun 12, 2024
@kris-brown kris-brown self-assigned this Jun 12, 2024
@kris-brown kris-brown merged commit a35203e into main Jun 13, 2024
10 checks passed
@kris-brown
Copy link
Collaborator Author

kris-brown commented Jun 13, 2024

I merged this since it was pretty benign (only interacts with the nauty code which is as of yet unused by general public, merely adds documentation + a tiny bugfix)

@epatters epatters deleted the fix_nauty branch June 14, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant