Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InterTypes #75

Merged
merged 14 commits into from
Nov 2, 2023
Merged

InterTypes #75

merged 14 commits into from
Nov 2, 2023

Conversation

olynch
Copy link
Member

@olynch olynch commented Oct 30, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Attention: 122 lines in your changes are missing coverage. Please review.

Comparison is base (0e7fa97) 91.70% compared to head (eeaf893) 87.22%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   91.70%   87.22%   -4.48%     
==========================================
  Files          17       22       +5     
  Lines        1362     1840     +478     
==========================================
+ Hits         1249     1605     +356     
- Misses        113      235     +122
Files Coverage Δ
src/ACSets.jl 100.00% <ø> (ø)
src/Schemas.jl 96.77% <ø> (ø)
src/intertypes/InterTypes.jl 89.28% <89.28%> (ø)
src/intertypes/sexp.jl 76.19% <76.19%> (ø)
src/intertypes/python.jl 78.33% <78.33%> (ø)
src/intertypes/julia.jl 85.50% <85.50%> (ø)
src/intertypes/json.jl 53.19% <53.19%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olynch olynch mentioned this pull request Oct 30, 2023
Closed
@epatters epatters changed the title Intertype InterTypes Oct 31, 2023
@epatters epatters added the enhancement New feature or request label Oct 31, 2023
@olynch olynch requested a review from jpfairbanks October 31, 2023 17:40
lukem12345
lukem12345 reviewed Oct 31, 2023
View reviewed changes
src/intertypes/json.jl
using MLStyle
import JSON3

struct JSONFormat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

abstract type SerialFormat end
Struct JSONFormat <: SerialFormat end

?
Suppose it doesn’t matter if no other Serial formats are on the radar.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, I also want s-expression and msgpack serialization

@lukem12345
Copy link
Member

lukem12345 commented Nov 2, 2023 •
edited
Loading

I just got a WARNING: both GATlab and ACSets export “toexpr”; uses of it in module CSets must be qualified. I am using a ]dev of this branch on a Decapodes dev branch.

Not causing an error, just a heads up.

@jpfairbanks jpfairbanks merged commit c9c5c7d into main Nov 2, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukem12345 lukem12345 lukem12345 left review comments

@jpfairbanks jpfairbanks jpfairbanks approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olynch @lukem12345 @jpfairbanks @epatters