Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homomorphism should error if there are multiple homomorphisms #922

Closed
kris-brown opened this issue Jul 3, 2024 · 0 comments · Fixed by #926
Closed

Homomorphism should error if there are multiple homomorphisms #922

kris-brown opened this issue Jul 3, 2024 · 0 comments · Fixed by #926
Assignees

Comments

@kris-brown
Copy link
Contributor

Often there is a natural choice of a homomorphism, which we obtain by calling homomorphism(X,Y; kw...).

This is unambiguous when there is a unique one. It's a common footgun for users when there happen to be multiple ones, and the automated search returns a morphism which is not what we were thinking of. It's quite rare in fact to want a particular but arbitrary morphism (such that which one you get is dependent on the implementation details of homomorphism). This should be allowed behavior (via a keyword argument, unique) but not default.

This would technically be a breaking change, but we could also argue that code which (implicitly) relies on hom search implementation details is incorrect code.

@kris-brown kris-brown self-assigned this Jul 3, 2024
@kris-brown kris-brown linked a pull request Jul 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant