You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The guidelines call for the text to be aligned at the bottom with 10dp underneath. This library has the bottom of the text higher than that (like 13 dp)
If you look at the guidelines the bottom of the text is exactly aligned at 10dp. But in the library if I change the bottom padding to 0, you'll see that there is still some padding (probably built in to TextView) above the bottom of the screen (which explains the discrepancy).
The problem with this is that the text is too high and the icons will not have a gap between them and the top of the text if you use the full 24x24. Also the spacing below the text looks awkwardly larger than it should be.
If you take a screen shot of the google photos app and compare its bottombar to this library - you will see the spacing issue.
Something needs to be changed with the padding at the bottom to compensate for the textview's built in padding.
Through tweaking things it looks like bottom padding of 7dp makes the bottom of the text line up correctly at 10dp
The text was updated successfully, but these errors were encountered:
The guidelines call for the text to be aligned at the bottom with 10dp underneath. This library has the bottom of the text higher than that (like 13 dp)
https://material.io/guidelines/components/bottom-navigation.html#bottom-navigation-specs
If you look at the guidelines the bottom of the text is exactly aligned at 10dp. But in the library if I change the bottom padding to 0, you'll see that there is still some padding (probably built in to TextView) above the bottom of the screen (which explains the discrepancy).
The problem with this is that the text is too high and the icons will not have a gap between them and the top of the text if you use the full 24x24. Also the spacing below the text looks awkwardly larger than it should be.
If you take a screen shot of the google photos app and compare its bottombar to this library - you will see the spacing issue.
Something needs to be changed with the padding at the bottom to compensate for the textview's built in padding.
Through tweaking things it looks like bottom padding of 7dp makes the bottom of the text line up correctly at 10dp
The text was updated successfully, but these errors were encountered: