Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some automation failures in the Windows CI do not fail the build #644

Open
mokagio opened this issue Nov 4, 2024 · 0 comments
Open

Some automation failures in the Windows CI do not fail the build #644

mokagio opened this issue Nov 4, 2024 · 0 comments
Assignees

Comments

@mokagio
Copy link
Contributor

mokagio commented Nov 4, 2024

I don't know where the issue lies, if in the way we call the scripts, if in how Buildkite runs them from the root, or elsewhere. Notice the logs in this build:

[2024-11-04T01:31:45Z] file:///C:/buildkite-agent/builds/ci-windows-i-08444a988c914038f-1/automattic/studio/scripts/confirm-tag-matches-version.mjs:17
[2024-11-04T01:31:45Z] 	throw new Error( 'Build was not triggered by a new tag' );
[2024-11-04T01:31:45Z] 	      ^
[2024-11-04T01:31:45Z]
[2024-11-04T01:31:45Z] Error: Build was not triggered by a new tag
[2024-11-04T01:31:45Z]     at file:///C:/buildkite-agent/builds/ci-windows-i-08444a988c914038f-1/automattic/studio/scripts/confirm-tag-matches-version.mjs:17:8
[2024-11-04T01:31:45Z]     at ModuleJob.run (node:internal/modules/esm/module_job:217:25)
[2024-11-04T01:31:45Z]     at async ModuleLoader.import (node:internal/modules/esm/loader:316:24)
[2024-11-04T01:31:45Z]     at async loadESM (node:internal/process/esm_loader:34:7)
[2024-11-04T01:31:45Z]     at async handleMainPromise (node:internal/modules/run_main:66:12)
[2024-11-04T01:31:45Z]
[2024-11-04T01:31:45Z] Node.js v20.9.0
[2024-11-04T01:31:46Z] Verifying Windows 10 SDK location...

When confirm-tag-matches-version.mjs threw, the CI job should have failed. Yet it continued.

@mokagio mokagio self-assigned this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants