Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect payment method logos used on WooPayment Settings #10209

Closed
brettshumaker opened this issue Jan 21, 2025 · 1 comment · Fixed by #10213
Closed

Incorrect payment method logos used on WooPayment Settings #10209

brettshumaker opened this issue Jan 21, 2025 · 1 comment · Fixed by #10213
Assignees
Labels
focus: checkout payments type: bug The issue is a confirmed bug.

Comments

@brettshumaker
Copy link
Contributor

Describe the bug

This issue was discovered during GlobalStep testing. The logos for iDeal and Bancontact used on the WooPayments Settings screen are the incorrect size/aspect ratio. It looks like this was introduced in #10167 when some assets in assets/images/payment-methods/ were changed. cc @elazzabi

To Reproduce

  1. Ensure your WooPayments account has support for iDeal and Bancontact
  2. Go to Payments > Settings
  3. Scroll to Payments accepted on checkout
  4. See a misalignment of payment method names.
  5. See that the size of the iDeal and Bancontact logos, and the white space around them, don't match the other logos.

Actual behavior

The logos in the "Payment Methods" section on the WooPayments Settings screen are not consistently sized. The payment method names and descriptions in the "Payment Methods" section on the WooPayments Settings screen are not properly aligned.

Screenshots

Before
Image

After
Image

Expected behavior

All logos in the "Payment Methods" section on the WooPayments Settings are consistently sized and their names and descriptions are properly aligned.

Desktop (please complete the following information):

  • Browser Brave (Chromium based)

Additional context

The organization of the assets/images folder is confusing regarding payment methods. Two folders contain images related to payment methods: payment-methods and payment-method-icons. The payment method classes use the images in assets/images/payment-methods for display in various instances in the plugin with the settings screen being one.

@brettshumaker brettshumaker added focus: checkout payments type: bug The issue is a confirmed bug. labels Jan 21, 2025
@elazzabi
Copy link
Member

Thanks for raising this @brettshumaker ! I'll look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: checkout payments type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants