Browser selection

[Valair]

We are experiencing an issue where the BrowserSelector.getAllBrowsers seems to pick only the phone default browser.

The documentation suggests to avoid authorization_user_agent WEBVIEW, in fact following the suggested best practice for mobile Google does not allow logging in using webview agent, but if the user has a supported browser installed (e.g. Chrome) and the default one isn't in the supported list (e.g. Mi Browser), the library:

• uses webview, if authorization_user_agent is DEFAULT
• reports the missing browser error string if authorization_user_agent is BROWSER

The only workaround we found is to manually change the default browser to a supported one.

Modifying the BrowserSelector.getAllBrowsers method and the BROWSE_INTENT to match the AppAuth library (which it is working in another project) seem to solve the problem and the library is able to use a supported browser even if it's not the default one.

Reading the authorization_user_agent documentation, it seems that this is the intended behavior for value BROWSER, but not for DEFAULT.

Am I missing something to allow the library to check for all installed browsers?
I think a more user-friendly behavior should be to be able to use a supported browser if it is installed and the default one isn't supported, rather than forcing the user to change his/her default browser.

[paulkagiri]

Hello @Valair, are you still experiencing this?

[Valair]

Hi @paulkagiri , yes I've updated to [email protected], which uses [email protected], but the issue remains.

Example scenario
Installed browsers:

• Chrome
• Mi Browser
• Firefox
• Brave

If the default system browser is Mi Browser or Brave, using authorization_user_agent DEFAULT cause the webview to be opened (so the user is unable to login with a google account), while setting it to BROWSER cause the missing browser error.
Changing the default system browser to Chrome or Firefox the library works as expected.

As a workaround, I'm currently using a custom version of this library with a modified version of the BrowserSelector.getAllBrowsers.