Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize field selection with graph depending on selected mode #70

Closed
rodolakis opened this issue Feb 7, 2024 · 2 comments · Fixed by #78
Closed

Synchronize field selection with graph depending on selected mode #70

rodolakis opened this issue Feb 7, 2024 · 2 comments · Fixed by #78
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rodolakis
Copy link
Collaborator

rodolakis commented Feb 7, 2024

If not Auto-off:

  • uncheck a box removes the corresponding curves from the graph (related to Unchecking a checkbox removes the signal from the graph #38)
  • remove a curve from the graph uncheck the corresponding curves
  • checking a box adds it automatically on the graph
  • if a new positioner is checked, automatically update the graph (in both auto-replace and auto-add)
@rodolakis rodolakis added the enhancement New feature or request label Feb 7, 2024
@rodolakis rodolakis added this to the v1.0 milestone Feb 7, 2024
@rodolakis rodolakis self-assigned this Feb 7, 2024
@rodolakis rodolakis added this to mdaviz Feb 7, 2024
@rodolakis rodolakis moved this to Todo in mdaviz Feb 8, 2024
@rodolakis
Copy link
Collaborator Author

rodolakis commented Feb 9, 2024

With this commit b1196d2:

1. in auto-off:

  • nothing happens when selection changes until you push Add or Replace button (intended)

2. in auto-replace:

  • checking a new DET replace the graph with the new selection
  • changing POS updates the graph
  • unchecking all POS default to index and update the graph
    DONE: check index box to visually indicate that POS= index

3. in auto-add:

  • checking a new DET adds it to the graph
  • DONE with 1e00ccc : checking a new POS updates the selection but nothing happens on the graph; may need to clear first
  • DONE with: 1e00ccc: removing all POS does default selection to index but the graph still does not update

TODO: the xlabel and title seem to disappear in some instances. To be investigated. New issue: #76

@rodolakis
Copy link
Collaborator Author

rodolakis commented Feb 9, 2024

With this commit 1e00ccc the graph gets cleared when:

  • the POS changes
  • the number of DET decreases

BUT:

rodolakis added a commit that referenced this issue Feb 9, 2024
rodolakis added a commit that referenced this issue Feb 10, 2024
rodolakis added a commit that referenced this issue Feb 10, 2024
@rodolakis rodolakis moved this from Coming Next to In Progress in mdaviz Feb 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in mdaviz Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant