Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ray and its protobuf dependency #84

Open
dan-fritchman opened this issue Sep 20, 2023 · 1 comment
Open

Update ray and its protobuf dependency #84

dan-fritchman opened this issue Sep 20, 2023 · 1 comment
Assignees
@tsai-henry

Comments

@dan-fritchman
Copy link
Contributor

Particularly so that it can play nice with Hdl21's parameter types.

Requires

        "protobuf~=4.23"

from
https://github.com/Vlsir/Vlsir/blob/ebd13f2fd8e10464ba0326aed952ea3b5650b695/bindings/python/setup.py#L41C1-L42C1
@dan-fritchman
Copy link
Contributor Author

Ray 2.0, which we currently use, requires protobuf < 4.0:

https://github.com/ray-project/ray/blob/cba26cc83f6b5b8a2ff166594a65cb74c0ec8740/python/setup.py#L306

Current Ray (2.7) would be compatible:

https://github.com/ray-project/ray/blob/df77af0b984a1d10c8bf2409d1f58ff20b065d27/python/setup.py#L355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsai-henry tsai-henry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dan-fritchman @tsai-henry