New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpAmp Metrics Follow-Ups #94

Open

dan-fritchman opened this issue Oct 24, 2023 · 0 comments

Assignees

Contributor

dan-fritchman commented Oct 24, 2023

Can you please follow up on these notes about your metrics extraction routines:

BwrcAmsMlDiscovery/AutoCkt/Server/autockt_server/opamps/tb.py

Line 118 in 923f843

FIXME @HarryYanH: what do you mean "best"?
https://github.com/BWRC-AMS-ML-Discovery/BwrcAmsMlDiscovery/blob/923f843867e4f68d76fe1b54ffa85bd4d0f27b9b/AutoCkt/Server/autockt_server/opamps/tb.py#L125C14-L125C23
BwrcAmsMlDiscovery/AutoCkt/Server/autockt_server/opamps/tb.py

Line 137 in 923f843

# FIXME: @HarryYanH: why are these all multiplied by 2?

dan-fritchman assigned HarryYanH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment