Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save/Load State Broken after Increasing Cycle Counter Size #3

Open
mesheets opened this issue Apr 7, 2020 · 0 comments
Open

Save/Load State Broken after Increasing Cycle Counter Size #3

mesheets opened this issue Apr 7, 2020 · 0 comments

Comments

@mesheets
Copy link
Member

mesheets commented Apr 7, 2020 •
edited
Loading

Save/Load state functionality has not yet been updated to account for the increase in cycle counter size, so neither saving nor loading will work at this time.

Additionally, due to the change in cycle counter size, any prior saved states will not be compatible with the updated program version. It might not be worth the effort to try to maintain backwards compatibility.
mesheets added a commit that referenced this issue Apr 7, 2020
@mesheets
Mitigate issue of emulator hanging on rollover of 32-bit cycle counter
e5a8131 
c.f. #2 , #3

Also address issue of last_cycles[1] (for the second 8-bit timer) not getting set to cycles in the t8_reset() method of timer8.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mesheets