Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify EEPROM functions to manage not only multiples of 4 inputs #328

Open
cua-cua opened this issue Oct 27, 2018 · 1 comment
Open

Modify EEPROM functions to manage not only multiples of 4 inputs #328

cua-cua opened this issue Oct 27, 2018 · 1 comment

Comments

@cua-cua
Copy link
Member

cua-cua commented Oct 27, 2018

The EEPROM functions (save and read) only manage input data multiple of 4 because the data is flashed with flash_program_word function. We have two alternatives:

  • Discard the data that can not be saved on words (current solution)
  • Include garbage data so the data always is contained on words. (proposed solution)

At this moment we only save maze sequence of 16*16 size so this is not a bug yet.

@cua-cua cua-cua mentioned this issue Oct 27, 2018
@Peque Peque added this to the OSHWDem 2018 milestone Oct 30, 2018
@cua-cua
Copy link
Member Author

cua-cua commented Nov 5, 2018

  • Change EEPROM read and save functions to have uint32_t pointer as input and output data.
    (Fom review comment: it is a bit more consistent within the loop, as you would not need BYTES_PER_WORD and could increment output_data++ or use (output_data + iter) (just like you do with memory_ptr)

@Peque Peque modified the milestones: OSHWDem 2018, Portugal 2019 Nov 7, 2018
@Peque Peque modified the milestones: Portugal 2019, OSHWDem 2019 May 16, 2019
@Peque Peque modified the milestones: OSHWDem 2019, Portugal 2020 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants