Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Tidy PECL extension #1

Open
acairns opened this issue Mar 12, 2014 · 4 comments
Open

Remove dependency on Tidy PECL extension #1

acairns opened this issue Mar 12, 2014 · 4 comments

Comments

@acairns
Copy link
Contributor

acairns commented Mar 12, 2014

At the moment, there is a dependency upon the Tidy pecl extension:
https://github.com/gathercontent/htmldiff/blob/master/src/Gathercontent/Htmldiff/Htmldiff.php#L48

Suggest removing this in favour of a dependency which can be managed via composer.

@legierski
Copy link
Contributor

"require": {
"php": ">=5.3.0",
"ext-tidy": "*"

},

?

On 12 March 2014 19:05, Andrew Cairns [email protected] wrote:

At the moment, there is a dependency upon the Tidy pecl extension:

https://github.com/gathercontent/htmldiff/blob/master/src/Gathercontent/Htmldiff/Htmldiff.php#L48

Suggest removing this in favour of a dependency which can be managed via
composer.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1
.

Peter Legierski

[email protected]
http://legierski.net
+44 7903 106 956

@acairns
Copy link
Contributor Author

acairns commented Mar 12, 2014

Can't we replace it with another package?
Or have it as a suggestion and pass it in as a driver?

@legierski
Copy link
Contributor

Not quite sure if there's another package that would do the job well. Tidy
seems to be a standard. I like the idea of having it as a suggestion and
pass driver.

On 12 March 2014 19:18, Andrew Cairns [email protected] wrote:

Can't we replace it with another package?
Or have it as a suggestion and pass it in as a driver?


Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-37451864
.

Peter Legierski

[email protected]
http://legierski.net
+44 7903 106 956

@gajus
Copy link

gajus commented Apr 25, 2014

Depending on what you are looking to Tidy, consider https://github.com/gajus/dindent. Came across this topic while researching a similar issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants