Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numba does not reproduce Python results #190

Open
ilhamv opened this issue Apr 28, 2024 · 1 comment
Open

Numba does not reproduce Python results #190

ilhamv opened this issue Apr 28, 2024 · 1 comment
Labels
bug Something isn't working as intended invalid This doesn't seem right

Comments

@ilhamv
Copy link
Member

ilhamv commented Apr 28, 2024 •
edited
Loading

Numba does not reproduce the Python result for cooper2 in the regression test. The difference comes only from work index 17 (idx_work == 17 in loop.py). The issue only shows up if run with the original problem reflective BCs AND mcdc.implicit_capture.

The current, temporary, "fix" is to turn off the implicit capture.

The recommended action is to locate the issue by following all tally scorings happening in the said work index.
@ilhamv ilhamv added the invalid This doesn't seem right label Apr 28, 2024
ilhamv added a commit to ilhamv/MCDC that referenced this issue Apr 28, 2024
@ilhamv
Temporary fix for Numba not reproducing Python (Issue CEMeNT-PSAAP#190)
023fceb
@clemekay clemekay added the bug Something isn't working as intended label Aug 13, 2024
@ilhamv
Copy link
Member Author

ilhamv commented Aug 14, 2024

The issues showed up in #186. I'll get back to it when it is time to merge the optimizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilhamv @clemekay