Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU regression testing and reproducibility #225

Open
2 tasks
clemekay opened this issue Aug 13, 2024 · 3 comments
Open
2 tasks

GPU regression testing and reproducibility #225

clemekay opened this issue Aug 13, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request gpu numba Numba-related issues

Comments

@clemekay
Copy link
Collaborator

Currently, GPU results do not exactly reproduce CPU results for regression tests. This seems to be because of an issue with numba's memory re-allocation (#224, also here).

For now, we plan to create GPU-specific answer files to:

  • ensure GPU reproducibility within a single architecture when code changes are made,
  • ensure GPU reproducibility across architectures.

If numba were to change how it handles the memory issue, that could break our reproducibility; that would also be the case for CPU, and that hasn't happened yet. For future numba version releases, we should check back with this issue before supporting the new versions.

@clemekay clemekay added enhancement New feature or request numba Numba-related issues gpu labels Aug 13, 2024
@clemekay clemekay changed the title Address GPU reproducibility GPU regression testing and reproducibility Aug 13, 2024
@ilhamv
Copy link
Member

ilhamv commented Aug 14, 2024

I want to make sure:
(1) the issue (#224) also applies to the current CPU mode and
(2) that GPU mode does not reproduce the CPU mode results may be due to other issues,
right @braxtoncuneo?

@ilhamv
Copy link
Member

ilhamv commented Aug 15, 2024

GPU is found to reproduce SOME of the CPU results. The following may be a useful reference to help point out what breaks the CPU-GPU reproducibility:

Screenshot 2024-08-15 at 12 00 45 PM image image

cc: @braxtoncuneo, @jpmorgan98

@ilhamv
Copy link
Member

ilhamv commented Aug 15, 2024

I attempted to create the GPU regression test keys here: https://github.com/ilhamv/MCDC/tree/gpu_regression_test

However, I found that the current GPU implementation is not reproducing its own solution for two problems:

  • inf_shem361_k_eigenvalue and
  • smrg7

cc: @braxtoncuneo, @jpmorgan98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gpu numba Numba-related issues
Projects
None yet
Development

No branches or pull requests

2 participants