Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Separate Layer and Feature Layer #306

Open
1 task
MurrayLF opened this issue Jul 2, 2021 · 3 comments
Open
1 task

[Story] Separate Layer and Feature Layer #306

MurrayLF opened this issue Jul 2, 2021 · 3 comments

Comments

@MurrayLF
Copy link

MurrayLF commented Jul 2, 2021

Separate Layers based upon function: rendering vs. device

Layers for rendering and for the device itself are currently intertwined/conflated. These should be separated for improved structure and easier implementation of additional layer types (e.g.; integration)

Existing code will need to be refactored to remove all instances of feature addition/removal from inside the microfluidic model and be moved to external functions.

We need to create an API that will simplify how new drawings/geometries are added/removed from the visualization layers

Additional Description

The layers types captured by the Microfluidic Device Model:

  1. FLOW
  2. CONTROL
  3. INTEGRATION

The visual type layers:

  1. Manufacturable artifacts (Feature)(s) (from FLOW, CONTROL and INTEGRATION)
  2. Text
  3. ComponentPort renders
  4. Additional Render Objects
  5. Grid + background

TODO - Create a class called PhysicalFeatures to allow the user and the toolchain to distinguish between UI elements and features that need to fabricate in the microfluidics.

Acceptance Criteria:

  • Unit Test
@rkrishnasanka rkrishnasanka added this to the TypeScript Port milestone Jul 3, 2021
@rkrishnasanka rkrishnasanka changed the title Separate Layer and Feature Layer [Story] [Story] Separate Layer and Feature Layer Jul 3, 2021
@rkrishnasanka
Copy link
Collaborator

@zyrrron it'll be good if you can be involved with this part of the project since this will be relevant to moving your visualization engine to use 3DuF. We are basically doing some of these things to simplify things for the GUIDE tool.

@zyrrron
Copy link
Collaborator

zyrrron commented Jul 3, 2021

I see. I am glad to do it.

@rkrishnasanka
Copy link
Collaborator

@MurrayLF I think separating the usage of the PhysicalFeature class is the only thing left on the docket for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants