generated from CMU-17313Q/NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed some emoji features in src/views/partials/chats/message.tpl #40
Open
Aya-Abdel-Hamid
wants to merge
229
commits into
CMU-17313Q:f24
Choose a base branch
from
CMU-17313Q:fixing-emoji-reaction
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixed some emoji features in src/views/partials/chats/message.tpl #40
Aya-Abdel-Hamid
wants to merge
229
commits into
CMU-17313Q:f24
from
CMU-17313Q:fixing-emoji-reaction
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add automated testing for inappropriate words user story
Added extra emoji reactions in src/views/partials/chats/message.tpl and made style changes in public/scss/chats.scss
Pull Request Test Coverage Report for Build 11427098931Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request further implements the feature that allows users to react to messages using a variety of emojis. Additionally, it includes several style enhancements to the reaction box to improve the user experience.
Changes Made :
Added Emoji Reactions:
Implemented a set of emoji buttons that users can click to react to messages.
Each emoji button displays an emoji and a count of reactions.
The following emojis have been added:
😮 (Surprised)
😢 (Crying)
👏 (Clapping)
🎉 (Party Popper)
🔥 (Fire)
💯 (100)
😊 (Smiling)
😍 (Heart Eyes)
❓ (Question Mark)
Style Enhancements for Reaction Box:
Updated the CSS to ensure the reaction box can wrap emojis into multiple rows.
Added padding, border, and background color to the reaction box for better visual appeal.
Ensured the reaction box takes the full width of its parent container and allows for vertical scrolling if needed.
Styled each emoji button with a lighter background color, green border, and rounded corners.
Added hover effects to the emoji buttons for better interactivity.
Files Modified :
src/views/partials/chats/message.tpl:
Added HTML structure for the emoji buttons within the reaction box.
public/scss/chats.scss:
Added and updated CSS styles for the reaction box and emoji buttons.