-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Static Analysis Tool: Plato #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid evidence of tool installation by concrete amount of files added to the codebase, tests are working well and tools are functioning properly. Looks good to me!
Pull Request Test Coverage Report for Build 11563041425Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully added tool reports and added tool to workflow for commits to the main branch, looks good to me!
Lint Test Failure Status ExplanationThe default ESLint workflow check is failing because Plato's configuration does not align with the default ESLint rules. This is expected behavior as Plato has its own linting standards which we want to preserve for consistency. Moreover, changing Plato's code to match the ESLint rules could make future updates and maintenance more difficult. Our dedicated Plato integration workflow ( |
I will preface and say this was not on the 313 Starter List of Static and Dynamic tools, but it was listed on the Other Resources link. I checked with Prof Milton and he said this was okay for having "at least one tool that is not from our starter list".
NOTE: The only test our implementation fails to pass are the lint tests. The TAs mentioned that if we were implementing a different static analysis tool, this is what should be happening (the TAs said it would be okay without the green check mark in this scenario).
Plato is a static analysis tool used to visualize code complexity.
Concrete evidence that you had successfully installed the tool:
Concrete evidence that you had successfully installed the tool: