Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean gui #23

Closed
wants to merge 17 commits into from
Closed

Clean gui #23

wants to merge 17 commits into from

Conversation

CarlosCancino-Chacon
Copy link
Member

No description provided.

…Not all classes are supported, but a lot, in particular the current ACCompanion subclasses. launch_acc_yaml.py has been modified to use config_gui and type annotations were added and modified in the hmm_accompanion.py and oltw_accompanion.py __init__ methods in order to make config_gui reliable. This is an initial push, properly commented code will come soon.
…WARNING this is not interoperable with the current YAML configuration code and is completely separate from that, however, this should be changed in the future.\n\rAnother big TODO, we have to think about how to handle paths in config files so that config files can easily be shared across file systems
@nimrodVarga
Copy link
Collaborator

Is it fine if I just resolve the conflicts via the web editor? The 2 conflicts are trivial (just remove some unnecessary imports and empty lines)

@manoskary manoskary linked an issue Oct 13, 2022 that may be closed by this pull request
@CarlosCancino-Chacon
Copy link
Member Author

This pull request is now obsolete, and its changes are now addressed by PR #27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choose midi port terminal GUI
2 participants