-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean gui #23
Closed
Closed
Clean gui #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Not all classes are supported, but a lot, in particular the current ACCompanion subclasses. launch_acc_yaml.py has been modified to use config_gui and type annotations were added and modified in the hmm_accompanion.py and oltw_accompanion.py __init__ methods in order to make config_gui reliable. This is an initial push, properly commented code will come soon.
…WARNING this is not interoperable with the current YAML configuration code and is completely separate from that, however, this should be changed in the future.\n\rAnother big TODO, we have to think about how to handle paths in config files so that config files can easily be shared across file systems
…rmination handling
Is it fine if I just resolve the conflicts via the web editor? The 2 conflicts are trivial (just remove some unnecessary imports and empty lines) |
This pull request is now obsolete, and its changes are now addressed by PR #27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.