Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TourDino has global styles #79

Open
keckelt opened this issue Aug 3, 2021 · 0 comments
Open

TourDino has global styles #79

keckelt opened this issue Aug 3, 2021 · 0 comments

Comments

@keckelt
Copy link
Member

keckelt commented Aug 3, 2021

Hi!

I noticed some side effects from TourDino's css in Coral.

As the name suggests, the _global.scss has some styles that are not scoped by any TourDino container element.
While most of them are for TourDino specific css classes, there is a general button style that cause issues as it aplies to any button with an img inside (as an icon): https://github.com/Caleydo/tourdino/blob/master/src/scss/base/_global.scss#L94-L105

Do you agree with me that this should be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant