Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digit grouping #2191

Open
fievel opened this issue Nov 25, 2024 · 1 comment
Open

Digit grouping #2191

fievel opened this issue Nov 25, 2024 · 1 comment
Labels
state: consensus-needed A consensus needs to be reached before this can be implemented

Comments

@fievel
Copy link

fievel commented Nov 25, 2024

When the scanning does not work (which can always happen depending on the reading hardware at the shop not well handling high reflective display for example), the cashier usually enter manually the code. However, I find difficult to copy correctly the code because it's just a big number without formatting. I think it would be a relatively cheap feature to implement some digit grouping of the code in order to ease manual operation.
I think many commercial alternatives of this app and also the original physical cards already feature this.

@TheLastProject
Copy link
Member

I get your point. I believe people have asked this before. There are a few things I'm unsure about:

  1. When do we group it? Only if the card id is full digits with no spaces or letters? Or also in some other cases? If so, which?
  2. Do we still display it with grouping in the details window (displayed when tapping the card ID)? What do we do when someone tries to copy the barcode? Do we copy it with or without grouping?
  3. What do we do when people explicitly set "Barcode value" (aka: the display value)? Do we still use the grouping or do we respect their custom settings (I guess respect their custom setting?)
  4. Do we need a way to disable this grouping? Do we need to somehow indicate we're displaying it differently than it is?
  5. How this feature (assuming it is implemented in other apps) ever lead to issues in stores? If so, is there anything we need to think of?

@TheLastProject TheLastProject added the state: consensus-needed A consensus needs to be reached before this can be implemented label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: consensus-needed A consensus needs to be reached before this can be implemented
Projects
None yet
Development

No branches or pull requests

2 participants