Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build / transpile everything on npm build #446

Open
vikoivun opened this issue Nov 10, 2017 · 7 comments
Open

Build / transpile everything on npm build #446

vikoivun opened this issue Nov 10, 2017 · 7 comments

Comments

@vikoivun
Copy link
Member

Currently a very large swath of build stuff happens on the first run of node server. Causing major downtime on upgrades.

Most everything should be done on npm build.

@akx
Copy link
Contributor

akx commented Nov 10, 2017

I'd say this sort of depends on #414. It's silly to implement a new build pipeline using an obsolete Webpack.

@Rikuoja
Copy link
Contributor

Rikuoja commented Dec 12, 2017

Yeah, so this should be ready to be done now!

@Rikuoja Rikuoja added the ready label Dec 12, 2017
@jonnetanninen
Copy link
Contributor

Would this be easiest for @akx to implement as he already has the knowledge of the current implementation? It will take me quite some time to understand what is going on here...

@Rikuoja
Copy link
Contributor

Rikuoja commented May 13, 2019

Probably @vikoivun has the best understanding of how we want to get the static build up to date now.

@farrukh8925
Copy link
Contributor

@vikoivun so, what may be your preference ? The yarn start already transpiles everything into /dist as static files, which can be used. So, how'd you want the build script to be different ? we can add certain optimisations

@vikoivun
Copy link
Member Author

vikoivun commented Jun 4, 2019

kerrokantasi-ui will have minimal server side rendering for FB. So the build only needs to be neat and clean. It would be nice if "production mode" would serve all client side stuff from previously processed files. Ie. it should start fast.

@Rikuoja
Copy link
Contributor

Rikuoja commented Apr 22, 2021

Well, this is a big thing. But should be done if there is time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants