Commission rates and closed pools

[mh-concordium]

Bug Description
Attempt to update commission rates on a closed pool will fail, it seems that such a change is not recognized as a change to the pool. I assume that this is handling for the closed pool. However, it seems a bit confusing that we can change rates for pool that is closed but then again those changes are not really enforced.

I assume that priority for this is low.

Steps to Reproduce
Add baker with closed pool ->try to change commission rates.
Update baker -> change commission rates again.

Expected Result
Values should be changed accordingly as selected by user. I assume this because commission rates are presented while signing tx in Ledger app.

Actual Result
Values are not changed in Ledger app. Commission rates stay default values.

Versions

• Software Version: 1.5.0
• OS: Windows, Mac

Update.commission.rates.mp4

[shjortConcordium]

Yeah, it should either skip the commission page, or put the changes into the transaction.