You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As it is now the wallet-connect-test-bench uses dapp-libraries and this is undesirable for several reasons.
The testing is meant to be on the wallet API directly, rather than through an indirection that could both hide some behaviour and introduce new bugs.
Negative scenarios such as sending an invalid schema to the wallet are not possible to test directly on the wallet since the error is raised before the wallet is reached.
We should revise the test app so that negative scenarios such as invalid schema actually reach the wallet.
The text was updated successfully, but these errors were encountered:
Would it make sense to have two wallet-test-benches? One front end uses the dApps libraries and a new front end is for testing plain calls to the wallet API (without any dApp library in-between). That way we keep the ability to test the dApp library and have a new front end for wallet API calls.
My idea for this test bench was to test the wallets mainly, not the other components, since testing wallets in connection with smart contracts has been challenging and no good tools are available other than sample apps which are very limited. But of course it could make sense to also have the ability to have a more extensive integration test. As for priorities for me the main one is to test the wallets still.
Bug Description
As it is now the wallet-connect-test-bench uses dapp-libraries and this is undesirable for several reasons.
We should revise the test app so that negative scenarios such as invalid schema actually reach the wallet.
The text was updated successfully, but these errors were encountered: