Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "wallet-connect-test-bench" should revise use of "dapp-libraries" #64

Open
abizjak opened this issue May 29, 2023 · 2 comments
Open
Assignees
Labels
[Type] Bug Something isn't working

Comments

@abizjak
Copy link
Contributor

abizjak commented May 29, 2023

Bug Description

As it is now the wallet-connect-test-bench uses dapp-libraries and this is undesirable for several reasons.

  • The testing is meant to be on the wallet API directly, rather than through an indirection that could both hide some behaviour and introduce new bugs.
  • Negative scenarios such as sending an invalid schema to the wallet are not possible to test directly on the wallet since the error is raised before the wallet is reached.

We should revise the test app so that negative scenarios such as invalid schema actually reach the wallet.

@abizjak abizjak added the [Type] Bug Something isn't working label May 29, 2023
@DOBEN
Copy link
Member

DOBEN commented Jun 5, 2023

Would it make sense to have two wallet-test-benches? One front end uses the dApps libraries and a new front end is for testing plain calls to the wallet API (without any dApp library in-between). That way we keep the ability to test the dApp library and have a new front end for wallet API calls.

@abizjak
Copy link
Contributor Author

abizjak commented Jun 5, 2023

Perhaps.

My idea for this test bench was to test the wallets mainly, not the other components, since testing wallets in connection with smart contracts has been challenging and no good tools are available other than sample apps which are very limited. But of course it could make sense to also have the ability to have a more extensive integration test. As for priorities for me the main one is to test the wallets still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants