Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of ptree dependency #75

Open
abizjak opened this issue May 11, 2023 · 0 comments
Open

Remove the use of ptree dependency #75

abizjak opened this issue May 11, 2023 · 0 comments
Labels
[Type] Change Request Some visible functionality should be change.

Comments

@abizjak
Copy link
Contributor

abizjak commented May 11, 2023

Description

The ptree dependency has not been updated for some time, and in particular it depends on nom version 5, which uses Rust features that will be deprecated

> warning: trailing semicolon in macro used in expression position
>    --> /home/abizjak/.cargo/registry/src/github.com-1ecc6299db9ec823/nom-5.1.2/src/combinator/macros.rs:509:35
>     |
> 509 |     map!(__impl $i, call!($f), $g);
>     |                                   ^
>     |
>    ::: /home/abizjak/.cargo/registry/src/github.com-1ecc6299db9ec823/nom-5.1.2/src/number/complete.rs:595:3
>     |
> 595 |   map!(i, le_u128, |x| x as i128)
>     |   ------------------------------- in this macro invocation
>     |
>     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
>     = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
>     = note: macro invocations at the end of a block are treated as expressions
>     = note: to ignore the value produced by the macro, add a semicolon after the invocation of `map`
>     = note: `#[allow(semicolon_in_expressions_from_macros)]` on by default
>     = note: this warning originates in the macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)

We use this for pretty printing the contract state as a key-value store. However that is not really useful for users since it is too complex.

We should either replace the use of ptree, or remove this state printing feature.

@abizjak abizjak added the [Type] Change Request Some visible functionality should be change. label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Change Request Some visible functionality should be change.
Projects
None yet
Development

No branches or pull requests

1 participant