Problems with Generated define.go

[DavePearce]

There are a number of issues with the generated define.go file. Here is a rough list, with minimal examples to follow:

• Formatting. The generated define.go does not pass gofmt (see Error when Missing Reduce #191)

• Unused Variables. The generated define.go declares variables even when they are not used. (see Unused Declaration for :array Column #179)

• More Unused Variables. The generated define.go still includes variables which are not used. (see Aliases cause Undeclared Variables in define.go #209)

• Undefined Variables. The generated define.go sometimes refers to variables which have not been declared (see Undefined Column Used in define.go #177)

• Duplicate Variables. The generated define.go declares variables more than once (see Duplicate Columns Declarations for Perspectives #178).

• Mul Arguments. The generated define.go has Mul expressions with more than two arguments (see Too Many Arguments for Mul in define.go #203).

@gusiri FYI.