Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notifications feed #5434

Open
nabramow opened this issue Jan 4, 2025 · 2 comments
Open

Add notifications feed #5434

nabramow opened this issue Jan 4, 2025 · 2 comments

Comments

@nabramow
Copy link
Collaborator

nabramow commented Jan 4, 2025

We want to make it easier for users to see when an action related to them happens. There is a backend api for this you can connect to:

rpc ListNotifications(ListNotificationsReq) returns (ListNotificationsRes);

Acceptance Criteria

  • Write a grpc/react-query for this to connect the backend call for ListNotifications to the frontend
  • Make the menu component, there will be different notification list items like friend request, etc (see below) so likely you want to have the custom list items and a default one.
  • Add icon to navigation and connect it up
  • write some tests

NOTE: Backend might not have everything we need, that's okay for now. Just do what we have, if you notice something missing make a note what and we can create a new ticket (or feel free to make the ticket).


DESIGN

Desktop - friend request example
Image

Desktop - notification settings hover/click example
Image

Mobile example
Image

@nabramow nabramow converted this from a draft issue Jan 4, 2025
@nabramow nabramow moved this to Needs details in Engineering Backlog ✏️ Jan 4, 2025
@nabramow nabramow added this to the Notifications milestone Jan 4, 2025
@nabramow nabramow self-assigned this Jan 4, 2025
@aapeliv
Copy link
Member

aapeliv commented Jan 5, 2025

NICOLE NEED TO CONFIRM - do we have backend for this. If not make backend ticket and get info for that.

This exists which is the first cut at this:

rpc ListNotifications(ListNotificationsReq) returns (ListNotificationsRes);

@nabramow nabramow moved this from Needs details to Needs design in Engineering Backlog ✏️ Jan 5, 2025
@nabramow nabramow assigned pepsicolacat and unassigned nabramow Jan 6, 2025
@nabramow
Copy link
Collaborator Author

nabramow commented Jan 6, 2025

@pepsicolacat Tagging you here to finish off the pop up over the pop up issue.

@nabramow nabramow changed the title Notifications feed Add notifications feed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready
Development

No branches or pull requests

3 participants