Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-8186] Preserve the appeals list the user was viewing #1053

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Sep 11, 2024

Description

In the appeals list view if you switch off of the Asked list to another list, like Given, then reload the page, you were taken back to the Asked list. This PR preserves the list that the user was on and only takes them to Asked if they didn't have appealStatus set in the filters in the URL.

MPDX-8186

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Sep 11, 2024
@canac canac requested a review from dr-bizz September 11, 2024 18:30
Copy link
Contributor

Preview branch generated at https://8186-preserve-appeals-page.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 3cde16b

No significant changes found

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

I think I found an issue. It correctly now puts you on the page you were on, but sometimes it takes you back to the page you were on previously.

Screen.Recording.2024-09-12.at.10.03.43.AM.mov

@canac
Copy link
Contributor Author

canac commented Sep 12, 2024

The URL logic that you copied is pretty buggy, and I have a backlog ticket for it: https://jira.cru.org/browse/MPDX-7879. I couldn't see the URL in your scree capture, but I'm pretty sure that when you clicked Received it changed the URL to received and then back to committed because I was seeing that. I think that fixing that would be a new issue with a larger estimate than 2.

@dr-bizz
Copy link
Contributor

dr-bizz commented Sep 13, 2024

@dr-bizz dr-bizz self-requested a review September 13, 2024 13:52
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will fix the other issue in another PR

@canac canac merged commit 1531998 into main Sep 13, 2024
19 checks passed
@canac canac deleted the 8186-preserve-appeals-page branch September 13, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants