Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-8480] Health Indicator preferences page #1218

Merged
merged 9 commits into from
Jan 9, 2025

Conversation

canac
Copy link
Contributor

@canac canac commented Dec 6, 2024

Description

If the user has a machine calculated goal available, display it in preferences. Also, add a button that resets the user's goal to the machine calculated goal.

MPDX-8480

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Dec 6, 2024
@canac canac requested a review from dr-bizz December 6, 2024 22:13
@canac canac self-assigned this Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Preview branch generated at https://8480-hi-preferences.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ther code looks great.

Previously the account currency was being used instead of the currency
of the machine calculated goal
@canac canac requested a review from dr-bizz January 6, 2025 20:24
@canac
Copy link
Contributor Author

canac commented Jan 6, 2025

@dr-bizz I've made a few changes here if you want to look them over:

  • Now the reset button sets the goal to null instead of whatever the calculated goal was at that moment in time
  • The machine calculated goal is rendered with the correct currency instead of the account's default currency

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and great improvements!

@canac
Copy link
Contributor Author

canac commented Jan 8, 2025

@dr-bizz I fixed this to load the last year of health indicator data and use the most recent one to fix the bug of no calculated goal showing up for January 2025 in staging.

@dr-bizz dr-bizz self-requested a review January 9, 2025 13:22
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@canac canac merged commit e9e0beb into health-indicator Jan 9, 2025
6 of 17 checks passed
@canac canac deleted the 8480-hi-preferences branch January 9, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants