-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPDX-8480] Health Indicator preferences page #1218
Conversation
Preview branch generated at https://8480-hi-preferences.d3dytjb8adxkk5.amplifyapp.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ther code looks great.
Previously the account currency was being used instead of the currency of the machine calculated goal
@dr-bizz I've made a few changes here if you want to look them over:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and great improvements!
src/components/Settings/preferences/accordions/MonthlyGoalAccordion/MonthlyGoalAccordion.tsx
Outdated
Show resolved
Hide resolved
src/components/Settings/preferences/accordions/MonthlyGoalAccordion/MonthlyGoalAccordion.tsx
Outdated
Show resolved
Hide resolved
@dr-bizz I fixed this to load the last year of health indicator data and use the most recent one to fix the bug of no calculated goal showing up for January 2025 in staging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Description
If the user has a machine calculated goal available, display it in preferences. Also, add a button that resets the user's goal to the machine calculated goal.
MPDX-8480
Checklist: