-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPDX-8515 - Fetching all pages on the coaches page #1258
Conversation
Preview branch generated at https://remove-limit-from-fetching-coaches.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against e7677b9 No significant changes found |
@dr-bizz Since most users don't have many people they're coaching, what do you think about just using |
9181681
to
bdbe0e4
Compare
@canac I've updated the query to use useFetchAllPages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! I've got a couple questions on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the flakiness with loading multiple pages concurrently, this looks great!
521d763
to
8027851
Compare
Description
As there was a limit on the number of coaches we could grab at one time from the GraphQL, I've implemented the
useFetchAllPages
functionality into the coaches page to ensure all coaches are rendered and not just the first 25.This PR continues the work done on PR #1257 Where I adjusted the number of coaches to be fetched from 25 to 100. However, the server limits us to only fetch 50 at a time.
To Test, please impersonate Shelley and navigate to her coaches page. You can find Shelley's email address from this HelpScout ticket
Checklist: