DGTAL cmake variables prefixed with DGTAL_

[dcoeurjo]

PR Description

your description here

Checklist

• Unit-test of your feature with Catch.
• Doxygen documentation of the code completed (classes, methods, types, members...)
• Documentation module page added or updated.
• New entry in the ChangeLog.md added.
• No warning raised in Debug mode.
• All continuous integration tests pass (Github Actions)

[BDoignies]

Shouldn't the version number also be capitalised for consistency?

DGtal/CMakeLists.txt

Lines 25 to 27 in cdccf7a

	set(DGtal_VERSION_MAJOR 1)
	set(DGtal_VERSION_MINOR 4)
	set(DGtal_VERSION_PATCH 2)

There is also the variable 'DGtalLibDependencies' as well as functions 'DGtal_add_test' and 'DGtal_add_example' which could be capitalised. Tough, the primary intention might only be for user-exposed variables...

[dcoeurjo]

Dunno.
Actually, I don't remember if these variables are somehow required for cmake to match with the "project" name (DGtal)

[BDoignies]

AFAIK versions for CMake are specified within the project function and can be accessed with, on most recent versions, CMAKE_PROJECT_VERSION / CMAKE_PROJECT_VERSION_{MAJOR/MINOR/PATCH/TWEAK} variables.

[dcoeurjo]

👍

[dcoeurjo]

so yes.. should be renamed