Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider returning subprocess.CompletedProcess instance from Engine1D.run() #56

Open
lizaclark opened this issue Oct 16, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@lizaclark
Copy link

It would be cool if Engine1D.run() returned the subprocess.CompletedProcess instance that is returned from the subprocess.run() call at

subprocess.run([mike1d_exec, str(dbOrMuppFile), f"-simulationid={simMuid}", f"-logfilename={log_file}"])
. This would allow users to check for subprocess errors within a script, if running a loop for instance.

https://docs.python.org/3/library/subprocess.html#subprocess.CompletedProcess

@ryan-kipawa
Copy link
Collaborator

Sounds like a really great suggestion @lizaclark, thanks! Would you be interested in submitting a pull request with this change?

@ryan-kipawa ryan-kipawa added the enhancement New feature or request label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants