You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
As an admin usher user, I would like to have APIs available to manage Permissions for a given Role. I would be able to list, create, & remove permissions for a Role.
The source files should be placed in the src/api_endpoints/roles folder
Questions
Should the POST take a single permission key or should we enhance to accept either a single key or an array of keys? Yes, and also change to PUT
What happens if the PUT is partially successful? ie. PUT sends 4 permission keys and 3 are valid and one is invalid? Are the three added with 200 success, three added with 400 error response, or none added with 400 error response?
The text was updated successfully, but these errors were encountered:
@mikelax Regarding POST /roles/:role_key/permissions, I recommend we use PUT method which accepts an array of permission keys similar to PUT /personas/{key}/permission
@mikelax Regarding the second question, I prefer returning a 400 error response with no permissions added, as it simplifies the API behavior and aligns with the logic we implemented for PUT /persona/{key}/permissions, where we validate all permissions before assigning them to the persona.
@mikelax Regarding the second question, I prefer returning a 400 error response with no permissions added, as it simplifies the API behavior and aligns with the logic we implemented for PUT /persona/{key}/permissions, where we validate all permissions before assigning them to the persona.
@k1ch I am ok with this as I agree it is simple to understand and I like consistency if we have already started with this implementation elsewhere.
Feature Overview
Is your feature request related to a problem? Please describe.
As an admin usher user, I would like to have APIs available to manage Permissions for a given Role. I would be able to list, create, & remove permissions for a Role.
API Design
/roles/:role_key/permissions
/roles/:role_key/permissions
/roles/:role_key/permissions/:permission_key
Implementation Notes
src/api_endpoints/roles
folderQuestions
The text was updated successfully, but these errors were encountered: