From 18e6593c76aacce55e9115bb5f9d1361c81a44ec Mon Sep 17 00:00:00 2001
From: Anton Hibl <75855379+antonhibl@users.noreply.github.com>
Date: Fri, 1 Dec 2023 09:09:44 -0700
Subject: [PATCH] Added depreciation notice to PvlObject::addLogGroup for ISIS3
v9.0 (#5347)
* added depreciation notice to PvlObject::addLogGroup for ISIS v9.0
* added changelog notice for depreciation warning
* redirected warning output to cerr instead of cout
---
CHANGELOG.md | 1 +
isis/src/base/objs/PvlObject/PvlObject.cpp | 3 +++
2 files changed, 4 insertions(+)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 768c418fc9..0cff9565f0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -60,6 +60,7 @@ release.
- Added new parameters ONERROR, ERRORLOG, and ERRORLIST to mosrange to provide better control over error behavior and provide diagnostics when problems are encountered processing the input file list.[#3606](https://github.com/DOI-USGS/ISIS3/issues/3606)
- Added ability to delegate calculation of nadir pointing to ALE [#5117](https://github.com/USGS-Astrogeology/ISIS3/issues/5117)
- Added --no-kernels flag to downloadIsisData [#5264](https://github.com/DOI-USGS/ISIS3/issues/5264)
+- Added notice for depreciation to PvlObject::addLogGroup function which will be depreciated in favor of Application::appendAndLog(https://github.com/DOI-USGS/ISIS3/issues/5310)
### Deprecated
diff --git a/isis/src/base/objs/PvlObject/PvlObject.cpp b/isis/src/base/objs/PvlObject/PvlObject.cpp
index 63955823f3..b1c0548a36 100644
--- a/isis/src/base/objs/PvlObject/PvlObject.cpp
+++ b/isis/src/base/objs/PvlObject/PvlObject.cpp
@@ -159,6 +159,9 @@ namespace Isis {
void PvlObject::addLogGroup(Isis::PvlGroup &group) {
addGroup(group);
Application::Log(group);
+ QString msg = "This function(PvlObject::addLogGroup) will be depreciated in ISIS3 v9.0 in "
+ "favor of Application::appendLogGroup";
+ std::cerr << msg << std::endl;
};
/**