Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PDS tools to read PDS4 labels #191

Open
jessemapel opened this issue Jun 20, 2019 · 6 comments
Open

Use PDS tools to read PDS4 labels #191

jessemapel opened this issue Jun 20, 2019 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@jessemapel
Copy link
Contributor

We should consider using the PDS4 tools (https://github.com/Small-Bodies-Node/pds4_tools) to read pds4 labels. I'm not sure how much it will help with but it makes sense to use the tools from the people who make and update the standard.

@jessemapel jessemapel added the enhancement New feature or request label Jun 20, 2019
@thareUSGS
Copy link
Contributor

+1. It would be good to support that effort and give back any updates we might provide. Like planetaryimage the only issue we might have is handling huge data sets (which is going to fairly rare for the ALE use case).

@jessemapel
Copy link
Contributor Author

@thareUSGS ALE doesn't hit the image data all, we're purely pulling the metadata off the label so that shouldn't be a problem.

@thareUSGS
Copy link
Contributor

Right - good point. I just notice the "version" of the tool you pointed at. This original Small Body code base has been taken over by the PDS Engineering Node and I think also incorporated PDS3 label support. I would recommend that we provide feedback to this version of the code. https://github.com/NASA-PDS-Incubator/pds-view

@jlaura
Copy link
Collaborator

jlaura commented Jun 20, 2019

👍 Docs look good too which makes usage much more straight forward. Is this the package that they are cool with us pushing to Conda-forge? If so, that would be awesome and makes this a win/win for us looking to parse and support pds4 labels inside of ALE.

@jessemapel
Copy link
Contributor Author

jessemapel commented Jun 20, 2019

@jlaura Yes, they said just make sure we post an issue so everyone knows what's going on. Also @thareUSGS that is an executable that builds on top of the pds tools.

@jlaura
Copy link
Collaborator

jlaura commented Jun 21, 2019

👍 Let's do it in the next sprint then if that makes sense. The total lack of dependencies makes this a piece of cake too. We can totally build it on Conda-forge with matplotlib and tkinter too.

We should use the first linked repo because they have a 1.1 release tagged. The other repo doesn't

@jessemapel jessemapel added this to the 0.2.0 Release milestone Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants