Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Express integration - v5.29.0+ reports incompatible version found when using Express v4 #5092

Open
vernak2539 opened this issue Jan 10, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@vernak2539
Copy link

vernak2539 commented Jan 10, 2025

Tracer Version(s)

5.29.0

Node.js Version(s)

22.11.0

Bug Report

When upgrading our dd-trace module, when we update to v5.29.0 or higher, we get the following output when debug mode is enabled.

$ DD_TRACE_DEBUG=true DD_TRACE_LOG_FILE=ddtrace_logs.log NODE_ENV=production node --import ./src/node-instrumentation.mjs src/server/index.mjs
Found incompatible integration version: [email protected]

I know that 5.29.0 is the same version that released support for express v5, but I would assume that express v4 is still supported based on the README (as it's based on node version).

Reproduction Code

// ./src/server/node-instrumentation.mjs 

import tracer from 'dd-trace';

tracer.init({
  hostname: process.env.DD_HOST,
  service: 'app',
  debug: process.env.DATADOG_DEBUG_ENABLED === 'true',
});

tracer.use('express')
// ./src/server/index.mjs

import express from 'express';

const app = express()
const port = 3000

app.get('/', (req, res) => {
  res.send('Hello World!')
})

app.listen(port, () => {
  console.log(`Example app listening on port ${port}`)
})

Start command

$ DD_TRACE_DEBUG=true DD_TRACE_LOG_FILE=ddtrace_logs.log NODE_ENV=production node --import ./src/node-instrumentation.mjs src/server/index.mjs

Error Logs

N/A

Tracer Config

tracer.init({
  hostname: process.env.DD_HOST,
  service: 'app',
  debug: process.env.DATADOG_DEBUG_ENABLED === 'true',
});

Operating System

Darwin XXX 24.2.0 Darwin Kernel Version 24.2.0

Bundling

No Bundling

@vernak2539 vernak2539 added the bug Something isn't working label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant