Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banning applies immediately across servers with a shared DB, unbanning does not #11

Open
GavJenks opened this issue Sep 1, 2019 · 1 comment

Comments

@GavJenks
Copy link

GavJenks commented Sep 1, 2019

Presumably, the plugin checks the actual database for logins, so a DB update on banning propagates (although I'm not sure if it is instant or not, actually). But when I unban somebody, it does not propagate and they are still blocked from logging onto a different shard. I have to go teleport aruond and unban them from every shard.

It is possible that if I only did it in one place, it would figure it out over the course of a day or something, but I can't rely on that, because I don't know if they'll log in somewhere while I'm waiting for updates to spread.

I would suggest that manually typed out bans and forgives by admins should both probably immediately update the database. It seems unnecessary to cache updates for something that only admins can type and that they only type once every few hours or days.

Unless I just got lucky, and logins are only using the cache, in which case dunno what to suggest

@ProgrammerDan
Copy link

ProgrammerDan commented Sep 1, 2019

The present issue is that the results of the commands are shard/server local and the DB commit is either immediate or very shortly delayed (some things are cached and applied in batches). Regardless of this, the other shards all have bans in memory for fast application, and they don't realize their cache is out of date.

So, somehow need to alert all co-users of the DB that they need to refresh their state. Thanks for this issue, will consider best approach!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants