Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Améliorer le logger #2687

Open
Feiryn opened this issue Nov 26, 2024 · 2 comments
Open

Améliorer le logger #2687

Feiryn opened this issue Nov 26, 2024 · 2 comments
Labels
core Changes in the core folder
Milestone

Comments

@Feiryn
Copy link
Contributor

Feiryn commented Nov 26, 2024

La boucle while a été temporairement remplacée par

		if (this.canWrite === LogWritingState.BUILDING || !this.fileStream!.writable) {
			console.error("Can't write to log file (the file is not ready or the permission is denied)");
			console.error("Logged text : " + loggedText);
			return;
		}

afin d'éviter d'avoir une boucle infinie. Je pense qu'il faudrait améliorer un peu le logger pour soit éviter d'avoir de la concurrence (peut-être avec un service centralisé ou un système de queue ?), ou alors prévoir un timeout

@Feiryn Feiryn added the core Changes in the core folder label Nov 26, 2024
@Feiryn Feiryn added this to the DraftBot V5 milestone Nov 26, 2024
@BastLast
Copy link
Member

on garde ça pr v5 ou v5.1 ?

@Feiryn
Copy link
Contributor Author

Feiryn commented Nov 26, 2024

Ouais peut-être en 5.1, rien d'urgent à mon avis

@Feiryn Feiryn modified the milestones: DraftBot V5, Après la 5.0 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes in the core folder
Projects
None yet
Development

No branches or pull requests

2 participants