runsuite_wrapper.pl is erroneously attributing test failures to i#1938 #2534
Comments
|
You can see the actual issue in the comments in that file: https://github.com/DynamoRIO/drmemory/blob/release_2.6.0/tests/runsuite_wrapper.pl#L203 #2342 is the culprit for the wrap_ tests in 32-bit debug. |
|
Re: reading comments in runsuite_wrapper.pl: |
derekbruening
pushed a commit
that referenced
this issue
Jan 15, 2025
…2526) The definition of strcasestr is char *strcasestr(const char *text, const char *pattern); but drmemory uses const char *strcasestr(const char *text, const char *pattern); This causes build errors when both /usr/include/string.h and common/utils.h are included in linux. The definition for strcasestr for C has always not had the `const` in the result type (going back to its original addition to glibc in 1997). Thus we're pretty safe in not breaking anything on *nix. The other main use case of drmemory's strcasestr is on Windows, which does not have strcasestr. Tested: $ cmake && make Also, there are failures in the clang and x86 workflows, but comparing the logs before/after shows all failures pre-exist this patch, no new failures. Here is the complete audit, all failures are pre-existing. Recorded (errantly) as i#1938 failures: - wrap_operators: "internal crash" (Received SIGSEGV) - filed as #2535 - wrap_cs2bug: CHECK_TRUNCATE_TYPE_sbyte(new_offs) (#2342) - pcache-use: "Usage error: meta-instr faulted? must set translation field and handle fault!" (#2202) - app_suite: vsyscall incorrect assumption (#2491) - app_suite.pattern: assert failure: save->ignore_next_delete == 0 (premature deletion) - filed as i#2537 - fuzz_threads: vsyscall incorrect assumption (#2491) Note: The above are marked as expected failures but [runsuite_wrapper.pl hardwires the addition of "i#1938" to test output](https://github.com/DynamoRIO/drmemory/blob/master/tests/runsuite_wrapper.pl#L281). #2534 Not currently recorded as expected failures (all #2491 - vsyscall incorrect assumption): - selfmod - syscalls_unix - clone - pthread_test - realloc Fixes #2522
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The test wrapper
runsuite_wrapper.plapparently hardwires all expected failures as being due to i#1938.ref: https://github.com/DynamoRIO/drmemory/blob/release_2.6.0/tests/runsuite_wrapper.pl#L281
To Reproduce
Submit a PR and study the ci-clang workflow test output.
Expected behavior
Each expected test failure should be attributed to the proper bug.
Otherwise developers have to spend unnecessary time auditing test failures to ensure new bugs aren't missed.
Screenshots or Pasted Text
From the ci-clang workflow here: #2532
Versions
HEAD as of commit f62daf1
OS: Test output reports Ubuntu 20.04.6
The text was updated successfully, but these errors were encountered: