-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bot fails to report back of the body contains too many characters #286
Labels
Comments
Full traceback:
|
EESSI/software-layer#726 fixes the issue that the overview doesn't correctly find the accelerator builds and just interprets all files as "other stuff". However, it may still be good to also implement a check on the length of the entire message that is used for the Github comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This build of CUDA was successful, but never reported back. In the bot logs, Kenneth saw
This is probably due to the fact that a) CUDA installs a lot of files and b) the prefixes are still quite long (e.g. for the UCX-CUDA module, the prefix was
accel/nvidia/cc80/modules/all/UCX-CUDA/1.14.1-GCCcore-12.3.0-CUDA-12.1.1.lua
), since we should still strip theaccel/nvidia/cc80/
part.It's probably good if the bot limits the message body in case it is too long. It's better to hard cut it, and add a final line that says the message was cut short because it was too long, then to get no response at all. Alternatively (but this would have to happen in the
software-layer
, we should limit the size of theartifacts
list, so that things that come after it (status, test result, etc) would still be displayed...The text was updated successfully, but these errors were encountered: