Fix23

[jialinl6]

Fixes #23
captures #23

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 80.36%. Comparing base (a0d5144) to head (5aa4c11).
Report is 1 commits behind head on main.

Files	Patch %	Lines
src/VBS.jl	60.00%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   84.17%   80.36%   -3.81%     
==========================================
  Files          11       11              
  Lines         139      163      +24     
==========================================
+ Hits          117      131      +14     
- Misses         22       32      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ctessum]

Thanks! Just a couple of suggestions above. Also it would be good if you can add a documentation page that describes the algorithm and demonstrates how to use it, for example including the analysis in Kai's spreadsheet that reproduces the figure in the original paper.

[ctessum]

Thanks! Just a couple of suggestions above. Also it would be good if you can add a documentation page that describes the algorithm and demonstrates how to use it, for example including the analysis in Kai's spreadsheet that reproduces the figure in the original paper.

[ctessum]

Also you can delete the file src/Low VOC, because this should supersede that VBS version.

[ctessum]

Gov4Git notices

On Monday, 01-Apr-24 15:11:10 UTC by Gov4Git dev

Notice fvs7ij

Started managing this PR as Gov4Git proposal 27 with initial approval score of 0.000000.

This project is managed by Gov4Git, a decentralized governance system for collaborative git projects.
To participate in governance, install the Gov4Git desktop app.

[jialinl6]

The documentation looks like this: VBS · Aerosol.jl.pdf

[ctessum]

Thanks!

[ctessum]

Gov4Git notices

On Friday, 05-Apr-24 20:24:44 UTC by Gov4Git dev

Notice pdayz2

This PR's approval score is now 3.000000.
The cost of review is 9.000000.
The projected bounty is now 0.000000.

Notice u5i4ul

The set of eligible issues claimed by this PR is now empty.

[ctessum]

Gov4Git notices

On Friday, 05-Apr-24 20:38:34 UTC by Gov4Git dev

Notice dxkvjc

This PR, managed as Gov4Git proposal 27, has been closed 🎉

The PR approval tally was 3.000000.

Bounty of 0.000000 credits was donated to the community's matching fund.

Resolved issues:

Rewarded PR reviewers:

• Reviewer @ctessum was awarded 9.000000 credits

Tally breakdown by user:

• User @ctessum contributed 3.000000 votes