Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global auth for all sites is not disabled after deleting user #34

Open
aronwp opened this issue Nov 30, 2018 · 5 comments · May be fixed by #53
Open

global auth for all sites is not disabled after deleting user #34

aronwp opened this issue Nov 30, 2018 · 5 comments · May be fixed by #53
Assignees
@PiyushKhurana

Comments

@aronwp
Copy link

aronwp commented Nov 30, 2018

when creating a new global auth user i.e "ee auth create global" it password protects all sites. deleting the new user does not deactivate the password prompt on all sites. on https://easyengine.io/commands/auth/delete/ it says use the command below but it does not work

Remove global auth on all sites (but not admin tools) with default username(easyengine)
$ ee auth delete example.com --site

Error: Parameter errors:
unknown --site parameter

I found a workaround by running ee global auth delete (this deletes all users and generates a new auth for ee-admin tools) after you will need to create a new auth for any site on the server i.e "ee auth create example.com" and then delete "ee auth delete example.com"

these steps remove the password prompt from all sites.
@mrrobot47
Copy link
Member

@aronwp to remove the global auth the syntax is ee auth delete global. The syntax in handbook is outdated. Thank you for noticing and reporting the issue. This will be fixed asap.

@mrrobot47 mrrobot47 transferred this issue from EasyEngine/easyengine Nov 30, 2018
@mrrobot47 mrrobot47 mentioned this issue Nov 30, 2018
Merged
@aronwp
Copy link
Author

aronwp commented Nov 30, 2018

@mrrobot47 thanks but it's still not working correctly. The ee auth delete global command deletes the global auth user but the password box still appears on all sites. The only way to remove global auth from sites is after ee auth delete global need to run ee auth create example.com and then ee auth delete example.com and then the password box is removed from all sites.

Basically the ee auth delete global removes the user but not the htpasswd for global auth

@mbtamuli
Copy link
Contributor

@mrrobot47 This looks like a problem. Reopening this issue. Let's investigate the cause of this issue and fix it.

@mbtamuli mbtamuli reopened this Nov 30, 2018
@PiyushKhurana PiyushKhurana self-assigned this Sep 21, 2021
@PiyushKhurana PiyushKhurana linked a pull request Sep 27, 2021 that will close this issue
Open
@PiyushKhurana PiyushKhurana linked a pull request Sep 27, 2021 that will close this issue
GH-34 Fix for ee auth delete global and ee auth delete global --ip #53
Open
@PiyushKhurana
Copy link

Since both HTTP Auth and IP Whitelisting are implemented in similar way the above problem can also occur in case of removing global ip whitelisting from the site using ee auth delete global --ip

Steps to produce the issue :-

  • Ensure site specific ip whitelisting or add using below command :-
    ee auth create example.test --ip=1.1.1.1 (this creates example.test_acl)
  • Ensure global ip whitelisting or add using below command :-
    ee auth create global --ip=8.8.8.8 (this creates default_acl)
  • Now when we remove site specific ip whitelisting
    ee auth delete example.test --ip (updates example.test_acl)
  • and then remove global ip whitelisting
    ee auth delete global --ip (deletes default_acl)

the global ip whitelisting is not removed from the site example.test
because the site specific ip whitelisting file example.test_acl remains undeleted

@PiyushKhurana
Copy link

Since both HTTP Auth and IP Whitelisting are implemented in similar way the above problem can also occur in case of removing global ip whitelisting from the site using ee auth delete global --ip

Steps to produce the issue :-

  • Ensure site specific ip whitelisting or add using below command :-
    ee auth create example.test --ip=1.1.1.1 (this creates example.test_acl)
  • Ensure global ip whitelisting or add using below command :-
    ee auth create global --ip=8.8.8.8 (this creates default_acl)
  • Now when we remove site specific ip whitelisting
    ee auth delete example.test --ip (updates example.test_acl)
  • and then remove global ip whitelisting
    ee auth delete global --ip (deletes default_acl)

the global ip whitelisting is not removed from the site example.test because the site specific ip whitelisting file example.test_acl remains undeleted

PR updated #53
Fix here 46571f7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PiyushKhurana PiyushKhurana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-34 Fix for ee auth delete global and ee auth delete global --ip PiyushKhurana/auth-command
5 participants
@aronwp @kirtangajjar @mbtamuli @mrrobot47 @PiyushKhurana