Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth delete should delete whitelisted IPs #28

Open
kirtangajjar opened this issue Oct 31, 2018 · 2 comments · May be fixed by #54
Open

Auth delete should delete whitelisted IPs #28

kirtangajjar opened this issue Oct 31, 2018 · 2 comments · May be fixed by #54
Assignees
@PiyushKhurana

Comments

@kirtangajjar
Copy link
Contributor

kirtangajjar commented Oct 31, 2018 •
edited
Loading

When we delete auth on site with ee auth delete <sitename>, we also expect that the site's whitelisted IPs will also be deleted. They don't get removed and we have to remove it manually with ee auth delete <sitename> --ip.

Now we have to ensure that Whitelisted IPs also get deleted with ee auth delete <sitename> and we don't have to delete them separately with ee auth delete <sitename> --ip.
@abhijitrakas
Copy link

So expected behaviour is as follows.

(1) Delete auth for user 'joe'
ee auth delete example.com --user=joe

(2) Delete auth for ip '192.0.0.2'
ee auth delete example.com --ip=192.0.0.2

(3) Delete all white listed ips
ee auth delete example.com --ip

(4) Delete all user and white listed ips
ee auth delete example.com

@kirtangajjar please confirm.

@mbtamuli
Copy link
Contributor

mbtamuli commented Jan 4, 2019

  1. Delete all users
    ee auth delete example.com --user

This will also be required to have a uniform interface along with point number 3 above.

@kirtangajjar kirtangajjar removed their assignment Sep 21, 2021
@PiyushKhurana PiyushKhurana linked a pull request Oct 6, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PiyushKhurana PiyushKhurana

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@kirtangajjar @mbtamuli @abhijitrakas @PiyushKhurana