Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #16381]Composer is focused and able to type after opening Search page from keyboard shortcut while showing emoji picker #16423

Closed
1 of 6 tasks
kavimuru opened this issue Mar 22, 2023 · 9 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kavimuru
Copy link

kavimuru commented Mar 22, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open any report
  2. Open EmojiPicker from right side of the composer
  3. navigate to the search page using CMD + K

Expected Result:

The Search page input will be focused

Actual Result:

The composer is focused and capturing input

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.88-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-03-22.at.6.57.51.AM.mov
Recording.137.mp4

Expensify/Expensify Issue URL:
Issue reported by: @getusha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679493836634509

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 22, 2023
@MelvinBot
Copy link

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@situchan
Copy link
Contributor

Note: This will be fixed by #16381 which fixes #15276 (slack convo)
cc: @hayata-suenaga @Santhosh-Sellavel

@Santhosh-Sellavel
Copy link
Collaborator

@michaelhaxhiu Please add HOLD on this one for #16381 , thanks

@hayata-suenaga hayata-suenaga changed the title Composer is focused and able to type after opening Search page from keyboard shortcut while showing emoji picker [HOLD #16381]Composer is focused and able to type after opening Search page from keyboard shortcut while showing emoji picker Mar 23, 2023
@Santhosh-Sellavel
Copy link
Collaborator

I'm not sure why this is being reported separately. Because @getusha has been hired there to collaborate with @situchan on that PR/Issue. This could be found as part of the testing and this is well within the scope of the same issue we are trying to solve there. So we can close this one as nothing is need to be done here cc: @hayata-suenaga @michaelhaxhiu

@situchan
Copy link
Contributor

The issue was created separately just because root cause is different. But yes, we can close this one.

@getusha
Copy link
Contributor

getusha commented Mar 23, 2023

@Santhosh-Sellavel I commented on the PR and discussed about the issue and was resolved on the PR now.

@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented Mar 23, 2023

The problem outline is the same when any modal is open and using shortcuts to open search/new chat results in no focus on the search input. So there is a no need for a separate issue.

@hayata-suenaga
Copy link
Contributor

@michaelhaxhiu I'm closing this issue now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

7 participants