Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Apply SOLID and Clean Code practices #75

Open
alvesitalo opened this issue Apr 7, 2022 · 0 comments
Open

[FEATURE] Apply SOLID and Clean Code practices #75

alvesitalo opened this issue Apr 7, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@alvesitalo
Copy link
Collaborator

alvesitalo commented Apr 7, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
A suggestion of some components that should follow Clean Code and SOLID practices for better code quality.

Describe the solution you'd like
Apply clean code and solid best practices to the analyzed components.

Describe alternatives you've considered
Clean Code:

  • app/javascript/legacy/bank_accounts/confirm/index.es6 (Clean Code)
  • app/javascript/legacy/campaigns/show/gift-option-button.js (Clean Code)
  • app/javascript/legacy/components/card-form.es6 (DIP)(Clean Code)
@alvesitalo alvesitalo added the enhancement New feature or request label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alvesitalo