Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Apply SOLID and Clean Code practices #78

Open
danieldagerom opened this issue Apr 7, 2022 · 0 comments
Open

[FEATURE] Apply SOLID and Clean Code practices #78

danieldagerom opened this issue Apr 7, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@danieldagerom
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
A suggestion of some components that should follow Clean Code and SOLID practices for better code quality.

Describe the solution you'd like
Apply clean code and solid best practices to the analyzed components.

Describe alternatives you've considered
Removing Unnecessary or redundant comments (Clean Code):

  • docs/event_definitions/common.ts
  • app/javascript/components/form_fields/MoneyTextField.tsx
  • app/javascript/components/users/SignInComponent.tsx
  • app/javascript/donate-button/donate-button.v2.ts
  • app/javascript/hooks/specs/useCurrentUserAuth/SignInFailed.spec.tsx
  • app/javascript/hooks/specs/useCurrentUserAuth/SignInSuccessful.spec.tsx
  • app/javascript/hooks/specs/useCurrentUserAuth/SignInInProgress.spec.tsx
  • app/javascript/hooks/specs/useCurrentUserAuth/SignInFailedAndThenSucceeded.spec.tsx

Fixing grammar error:

  • app/javascript/legacy/campaigns/new/wizard.js
@danieldagerom danieldagerom added the enhancement New feature or request label Apr 7, 2022
@danieldagerom danieldagerom self-assigned this Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant