Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit rate history per worker #70

Open
cnettel opened this issue Apr 3, 2016 · 1 comment
Open

Hit rate history per worker #70

cnettel opened this issue Apr 3, 2016 · 1 comment
Labels
Milestone

Comments

@cnettel
Copy link
Contributor

cnettel commented Apr 3, 2016

The hit rate history is per worker. This means that the meaning of hitrate2000 varies with the number of nodes. Another, complicating, issue is that events are not round-robined between workers in a fair way (with the psana backend). Thus, some hit history is trailing a long time.

Should the history be changed to be a total, not per worker, since the hitrate code anyway does an MPI reduction? This would give more comparable results when running in single or MPI mode, or varying the MPI width.

@daurer
Copy link
Contributor

daurer commented Apr 3, 2016

It would make sense and give more accurate results if we would have a
global history instead of per-worker, but who would keep that global
history in memory, the master? For large histories this could be a problem
for performance, I guess. But yeah, if performance is not an issue, I think
we should change to global hitrate history.

On Sun, Apr 3, 2016 at 7:49 AM, cnettel [email protected] wrote:

The hit rate history is per worker. This means that the meaning of
hitrate2000 varies with the number of nodes. Another, complicating, issue
is that events are not round-robined between workers in a fair way (with
the psana backend). Thus, some hit history is trailing a long time.

Should the history be changed to be a total, not per worker, since the
hitrate code anyway does an MPI reduction? This would give more comparable
results when running in single or MPI mode, or varying the MPI width.

b

@daurer daurer modified the milestone: Hotfixes 1.2 Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants