Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optional fields in the uncrashable config file #96

Open
monitz87 opened this issue Apr 4, 2023 · 0 comments
Open

Allow optional fields in the uncrashable config file #96

monitz87 opened this issue Apr 4, 2023 · 0 comments

Comments

@monitz87
Copy link

monitz87 commented Apr 4, 2023

Firstly, the docs don't specify that networkConfig and networkConfig.entityIdPrefixes must be defined and cannot be empty. Same thing goes for entitySettings.<ENTITY_NAME>.useDefault (though it can be empty, it must always be defined)

Secondly, these fields (IMO) should be optional. If I'm only managing one chain in my subgraph, and I don't want any prefix, a sensible default would be to assign empty string as a prefix for any chain. useDefault could very well default to {}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant